New rpc service to attach/detach a controller to a namespace.#237
New rpc service to attach/detach a controller to a namespace.#237VaibhavJMarvell wants to merge 1 commit into
Conversation
glimchb
left a comment
glimchb
left a comment
There was a problem hiding this comment.
how this si different from CreateNVMeNamespace ?
We have an existing customer whose use-case requires attaching/detaching specific controllers to a namespace. In the current scenario of |
so maybe just add field |
There was a problem hiding this comment.
+1 on the need for this API i.e. the need to explicitly enable/disable the namespace within a controller.
a few minor comments inline @VaibhavJMarvell
| (google.api.field_behavior) = REQUIRED | ||
| ]; | ||
| string controller = 2 [(google.api.field_behavior) = REQUIRED]; | ||
| string nv_me_namespace_id = 3 [(google.api.field_behavior) = REQUIRED]; |
There was a problem hiding this comment.
should this be common.v1.ObjectKey which bytes all ids are like that. Same for controller?
we could do that to, but this API would then become explicit enable/disable API to toggle namespace on controller. |
Added attach/detach controller to cater to use-case of an existing customer. Signed-off-by: Vaibhav Jain <vaibhavj@marvell.com> Signed-off-by: Michal Kalderon <mkalderon@marvell.com>
VaibhavJMarvell
left a comment
VaibhavJMarvell
left a comment
There was a problem hiding this comment.
I have changed the controller and namespace types to ObjectKey.
seems to me like we should use |
we need to add enable/disable in NameSpaceSpec if we do it via namespace object; that'd work too, but having an admin know to enable a namespace on a subsystem/controller is the ask here. |
agree, let's add Enable/Disable to |
|
@VaibhavJMarvell @jainvipin can you please continue this ? it is open for a long time |
3 participants
Added attach/detach controller to cater to use-case of an existing customer.
Signed-off-by: Vaibhav Jain vaibhavj@marvell.com
Signed-off-by: Michal Kalderon mkalderon@marvell.com